Ensure ASCII host case normalization happens before validation #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
5 tasks
bdraco
commented
Nov 30, 2024
bdraco
commented
Nov 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1442 +/- ##
==========================================
- Coverage 96.11% 96.08% -0.04%
==========================================
Files 31 31
Lines 5876 5882 +6
Branches 349 349
==========================================
+ Hits 5648 5652 +4
- Misses 202 204 +2
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1442 will not alter performanceComparing Summary
|
bdraco
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes a regression was introduced in #954 that prevented uppercase host names from working
#386 covered some of the paths, but we didn't have coverage for the build path
Are there changes in behavior for the user?
Allows uppercase hosts again
Related issue number
fixes #1441